Rain Data Missing on Bar Graph Every 31st of Month

Post Reply
User avatar
Sperry Russ
Observer
Observer
Posts: 18
Joined: Sun Aug 20, 2017 1:07 pm
Location: Florida
Station model: Davis Pro 2 Cabled
Software: CumulusMX V. 3
Contact:

Rain Data Missing on Bar Graph Every 31st of Month

Post by Sperry Russ » Wed Jul 04, 2018 6:18 pm

I just discovered while importing and checking some data that every month that has 31 days the rain data is missing on the bar graph. It shows up below the bar graph in the detailed info.

Graph1.JPG
Graph1.JPG (47.44 KiB) Viewed 15100 times
Graph2.jpg
Graph2.jpg (40.05 KiB) Viewed 15100 times

User avatar
Dehatter
Professional
Professional
Posts: 350
Joined: Sun Jan 07, 2018 5:11 am
Location: Matthews, NC, USA
Station model: Ecowitt WH80
Software: Ecowitt GW1000
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Dehatter » Sun Jul 08, 2018 8:08 pm

Sorry...but for the life of me, I cannot find the graph you show!! LOL

Can you provide the block/plugin where it is?

Tom
Image

User avatar
Sperry Russ
Observer
Observer
Posts: 18
Joined: Sun Aug 20, 2017 1:07 pm
Location: Florida
Station model: Davis Pro 2 Cabled
Software: CumulusMX V. 3
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Sperry Russ » Sun Jul 08, 2018 9:05 pm

As far as I know it is not a block or plugin. Just part of the template.

Go to the menu, then click Weather Station, then click Reports. Under the Monthly Reports choose the month and year, click Ok. Then click on precipitation. Then scroll down the page.

User avatar
Dehatter
Professional
Professional
Posts: 350
Joined: Sun Jan 07, 2018 5:11 am
Location: Matthews, NC, USA
Station model: Ecowitt WH80
Software: Ecowitt GW1000
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Dehatter » Sat Jul 14, 2018 7:07 am

Well by gosh you are right!

Mine does it too.

I have never gone to that report.

Tom
Image

User avatar
Sperry Russ
Observer
Observer
Posts: 18
Joined: Sun Aug 20, 2017 1:07 pm
Location: Florida
Station model: Davis Pro 2 Cabled
Software: CumulusMX V. 3
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Sperry Russ » Sat Jul 14, 2018 1:44 pm

I was using that report to check data I was importing.

User avatar
Dehatter
Professional
Professional
Posts: 350
Joined: Sun Jan 07, 2018 5:11 am
Location: Matthews, NC, USA
Station model: Ecowitt WH80
Software: Ecowitt GW1000
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Dehatter » Sat Jul 21, 2018 9:30 pm

Jachym. Any ideas on this one?

Tom
Image

User avatar
Johnny
Developer
Developer
Posts: 313
Joined: Sat Aug 19, 2017 10:16 pm
Location: Watford, Hertfordshire, England
Station model: Davis Vantage Pro2 Plus
Software: Meteobridge
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Johnny » Wed Aug 01, 2018 8:47 am

I've noticed the exact same problem from 9.6mm of rainfall we had on the 31st July 2018, it shows in the total and in the detail below the graph, but no bar appears on the graph.

31st-no-rain-on-graph.jpg
31st-no-rain-on-graph.jpg (26.53 KiB) Viewed 14927 times
Image
Davis Vantage Pro2 Plus: http://www.watfordweather.uk

wx_jon
Advisor
Advisor
Posts: 52
Joined: Tue Aug 29, 2017 8:54 pm
Location: Seattle, WA, USA
Station model: Davis Vantage Pro 2 Plus
Software: weeWX
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by wx_jon » Wed Aug 01, 2018 7:41 pm

I found the pesky bug. Change line 1163 of pages/station/reportMonthlyLoad.php from

Code: Select all

for($i=1;$i<$numberDays;$i++){
to

Code: Select all

for($i=1;$i<=$numberDays;$i++){
It's just a '<=' sign!
There's also another identical change at line 1280 which will add the 31st of the month to the range bar charts on temperature and other variables.
Last edited by wx_jon on Wed Aug 01, 2018 10:23 pm, edited 1 time in total.

User avatar
Sperry Russ
Observer
Observer
Posts: 18
Joined: Sun Aug 20, 2017 1:07 pm
Location: Florida
Station model: Davis Pro 2 Cabled
Software: CumulusMX V. 3
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Sperry Russ » Wed Aug 01, 2018 9:47 pm

Okay, thanks Jon.

User avatar
Johnny
Developer
Developer
Posts: 313
Joined: Sat Aug 19, 2017 10:16 pm
Location: Watford, Hertfordshire, England
Station model: Davis Vantage Pro2 Plus
Software: Meteobridge
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Johnny » Thu Aug 02, 2018 9:08 am

wx_jon wrote: Wed Aug 01, 2018 7:41 pm I found the pesky bug.
Hi Jon, thank you - it worked. I've know idea how you found that one character missing in all those lines of code, but it's done the trick.

31st-yes-rain-on-graph.jpg
31st-yes-rain-on-graph.jpg (7.41 KiB) Viewed 14901 times
Happy.jpg
Happy.jpg (11.07 KiB) Viewed 14901 times
Image
Davis Vantage Pro2 Plus: http://www.watfordweather.uk

User avatar
Dehatter
Professional
Professional
Posts: 350
Joined: Sun Jan 07, 2018 5:11 am
Location: Matthews, NC, USA
Station model: Ecowitt WH80
Software: Ecowitt GW1000
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by Dehatter » Mon Aug 06, 2018 6:08 am

All I can say is Nice One!!

Thank you very much,

Tom
Image

User avatar
LOBWX
Forecaster
Forecaster
Posts: 104
Joined: Sun Mar 11, 2018 6:43 pm
Location: Los Osos, CA
Station model: Ambient WS 1401-IP
Software: MeteoBridge
Contact:

Re: Rain Data Missing on Bar Graph Every 31st of Month

Post by LOBWX » Tue Aug 07, 2018 5:02 pm

Serious Dig Dug.
Thanks wx_jon.
Just BE NICE! That's all it takes to be a decent human...

Post Reply